Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug about tensor str in nonsymmetric cast and getitem in consist… #6239

Merged
merged 3 commits into from
Sep 12, 2021

Conversation

liufengwei0103
Copy link
Contributor

@liufengwei0103 liufengwei0103 commented Sep 11, 2021

  1. 支持非对称情况下的打印
  2. 解决GetItem在判断is_identity进行copy时,consistent tensor缺乏条件的问题。

@liufengwei0103 liufengwei0103 linked an issue Sep 11, 2021 that may be closed by this pull request
@wyg1997 wyg1997 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot September 12, 2021 11:32
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

OneFlow resnet50 time: 128.2ms (= 6410.0ms / 50, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 140.3ms (= 7012.7ms / 50, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.09 (= 140.3ms / 128.2ms)

OneFlow resnet50 time: 76.6ms (= 3828.0ms / 50, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 85.1ms (= 4253.1ms / 50, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.11 (= 85.1ms / 76.6ms)

OneFlow resnet50 time: 51.1ms (= 2554.4ms / 50, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 61.1ms (= 3052.6ms / 50, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.20 (= 61.1ms / 51.1ms)

OneFlow resnet50 time: 44.8ms (= 2237.8ms / 50, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 50.9ms (= 2545.7ms / 50, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.14 (= 50.9ms / 44.8ms)

OneFlow resnet50 time: 45.0ms (= 2249.7ms / 50, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 44.0ms (= 2199.1ms / 50, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 0.98 (= 44.0ms / 45.0ms)

OneFlow resnet50 time: 156.8ms (= 7840.5ms / 50, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 159.8ms (= 7990.7ms / 50, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.02 (= 159.8ms / 156.8ms)

OneFlow resnet50 time: 98.7ms (= 4933.1ms / 50, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 102.6ms (= 5128.4ms / 50, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.04 (= 102.6ms / 98.7ms)

OneFlow resnet50 time: 81.9ms (= 4096.4ms / 50, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 74.5ms (= 3725.2ms / 50, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 0.91 (= 74.5ms / 81.9ms)

OneFlow resnet50 time: 71.9ms (= 3596.4ms / 50, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 74.0ms (= 3699.3ms / 50, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.03 (= 74.0ms / 71.9ms)

OneFlow resnet50 time: 67.5ms (= 3374.2ms / 50, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 69.1ms (= 3457.2ms / 50, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.02 (= 69.1ms / 67.5ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review September 12, 2021 12:30
@oneflow-ci-bot oneflow-ci-bot merged commit 7713fda into master Sep 12, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the fix_bug_tensor_str_and_getitem branch September 12, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

非对称的 Eager Consistent Tensor 打印报错
3 participants