Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix var bug #7517

Merged
merged 19 commits into from
Feb 24, 2022
Merged

fix var bug #7517

merged 19 commits into from
Feb 24, 2022

Conversation

liufengwei0103
Copy link
Contributor

No description provided.

oneflow/user/kernels/variance_kernel.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 21, 2022 02:55
@github-actions
Copy link
Contributor

CI failed when running job: Build cpu. PR label automerge has been removed

@liufengwei0103 liufengwei0103 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 21, 2022 03:11
@oneflow-ci-bot oneflow-ci-bot removed their request for review February 21, 2022 03:16
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 22, 2022 10:19
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 22, 2022 12:43
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 22, 2022 17:28
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 23, 2022 05:05
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 23, 2022 12:31
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 23, 2022 19:33
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 23, 2022 20:43
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 23, 2022 22:57
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

✔️ OneFlow resnet50 time: 128.5ms (= 12850.9ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 141.6ms (= 14159.5ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.10 (= 141.6ms / 128.5ms)

✔️ OneFlow resnet50 time: 78.0ms (= 7795.4ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 85.4ms (= 8539.4ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.10 (= 85.4ms / 78.0ms)

OneFlow resnet50 time: 51.2ms (= 10236.0ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 58.6ms (= 11711.8ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.14 (= 58.6ms / 51.2ms)

OneFlow resnet50 time: 41.8ms (= 8369.4ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 43.7ms (= 8745.6ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.04 (= 43.7ms / 41.8ms)

OneFlow resnet50 time: 38.8ms (= 7756.8ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 38.2ms (= 7631.4ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 0.98 (= 38.2ms / 38.8ms)

✔️ OneFlow resnet50 time: 141.6ms (= 14155.3ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 162.1ms (= 16214.3ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.15 (= 162.1ms / 141.6ms)

OneFlow resnet50 time: 89.4ms (= 8935.6ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 101.5ms (= 10152.1ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.14 (= 101.5ms / 89.4ms)

OneFlow resnet50 time: 62.3ms (= 12466.0ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 73.4ms (= 14680.9ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.18 (= 73.4ms / 62.3ms)

OneFlow resnet50 time: 51.7ms (= 10348.7ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 68.4ms (= 13686.1ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.32 (= 68.4ms / 51.7ms)

OneFlow resnet50 time: 49.7ms (= 9940.7ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 59.1ms (= 11812.4ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.19 (= 59.1ms / 49.7ms)

@oneflow-ci-bot oneflow-ci-bot merged commit b8984a0 into master Feb 24, 2022
@oneflow-ci-bot oneflow-ci-bot deleted the fix_var_bug branch February 24, 2022 03:35
marigoold pushed a commit that referenced this pull request Mar 15, 2022
* fix var bug

* cuda malloc aligned size

* refine

* auto format by CI

* refine var kernel registe

* format

Co-authored-by: oneflow-ci-bot <ci-bot@oneflow.org>
Co-authored-by: oneflow-ci-bot <69100618+oneflow-ci-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants