Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix arange and add global unittest #7576

Merged
merged 4 commits into from
Feb 28, 2022
Merged

fix arange and add global unittest #7576

merged 4 commits into from
Feb 28, 2022

Conversation

hjchen2
Copy link
Contributor

@hjchen2 hjchen2 commented Feb 23, 2022

No description provided.

@hjchen2 hjchen2 requested a review from wyg1997 February 28, 2022 02:36
@hjchen2 hjchen2 enabled auto-merge (squash) February 28, 2022 02:37
wyg1997
wyg1997 reviewed Feb 28, 2022
View reviewed changes
python/oneflow/test/modules/test_consistent_arange.py
@globaltest
def test_arange(test_case):
for placement in all_placement():
# arange does not support split and partial_sum currently.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE：#7571 支持 S0 是这个 PR，后续要改一下这里的单测

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以

@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 28, 2022 03:38
@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: GeForce GTX 1080 

✔️ OneFlow resnet50 time: 128.5ms (= 12846.4ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 139.5ms (= 13949.4ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.09 (= 139.5ms / 128.5ms)

✔️ OneFlow resnet50 time: 76.5ms (= 7649.6ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 85.2ms (= 8524.6ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.11 (= 85.2ms / 76.5ms)

OneFlow resnet50 time: 53.9ms (= 10785.9ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 57.4ms (= 11470.5ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.06 (= 57.4ms / 53.9ms)

OneFlow resnet50 time: 45.3ms (= 9055.2ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 45.6ms (= 9123.9ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.01 (= 45.6ms / 45.3ms)

OneFlow resnet50 time: 39.6ms (= 7924.8ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 37.8ms (= 7559.7ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 0.95 (= 37.8ms / 39.6ms)

✔️ OneFlow resnet50 time: 142.0ms (= 14203.4ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 162.1ms (= 16214.7ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.14 (= 162.1ms / 142.0ms)

OneFlow resnet50 time: 87.6ms (= 8762.0ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 100.6ms (= 10058.0ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.15 (= 100.6ms / 87.6ms)

OneFlow resnet50 time: 63.1ms (= 12624.7ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 76.0ms (= 15197.3ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.20 (= 76.0ms / 63.1ms)

OneFlow resnet50 time: 51.0ms (= 10199.9ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 67.4ms (= 13481.6ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.32 (= 67.4ms / 51.0ms)

OneFlow resnet50 time: 48.3ms (= 9652.3ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 62.3ms (= 12452.3ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.29 (= 62.3ms / 48.3ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review February 28, 2022 05:04
@hjchen2 hjchen2 merged commit 285a665 into master Feb 28, 2022
@hjchen2 hjchen2 deleted the dev_fix_arange_and_add_global_unittest branch February 28, 2022 08:07
marigoold pushed a commit that referenced this pull request Mar 15, 2022
@hjchen2 @marigoold
fix arange and add global unittest (#7576)
92e69fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyg1997 wyg1997 wyg1997 approved these changes

@clackhan clackhan clackhan approved these changes

@daquexian daquexian Awaiting requested review from daquexian

@jackalcooper jackalcooper Awaiting requested review from jackalcooper

@oneflow-ci-bot oneflow-ci-bot Awaiting requested review from oneflow-ci-bot

Assignees
No one assigned
Labels
automerge bug test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hjchen2 @clackhan @wyg1997 @oneflow-ci-bot