Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm redundant output #9575

Merged
merged 3 commits into from Dec 10, 2022
Merged

rm redundant output #9575

merged 3 commits into from Dec 10, 2022

Conversation

shangguanshiyuan
Copy link
Contributor

@shangguanshiyuan shangguanshiyuan commented Dec 9, 2022 •
edited

删除distributed.launch下默认创建的log文件夹

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

Speed stats: 
GPU Name: GeForce GTX 1080 









❌ OneFlow resnet50 time: 140.3ms (= 14032.6ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 160.1ms (= 16014.9ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.14 (= 160.1ms / 140.3ms)

OneFlow resnet50 time: 85.7ms (= 8569.8ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 101.0ms (= 10103.2ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.18 (= 101.0ms / 85.7ms)

OneFlow resnet50 time: 57.9ms (= 11577.8ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 76.3ms (= 15251.3ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.32 (= 76.3ms / 57.9ms)

OneFlow resnet50 time: 45.4ms (= 9079.1ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 67.6ms (= 13521.1ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.49 (= 67.6ms / 45.4ms)

OneFlow resnet50 time: 41.1ms (= 8213.2ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 60.7ms (= 12140.8ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.48 (= 60.7ms / 41.1ms)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

CI failed when running job: cuda-misc. PR label automerge has been removed

@github-actions github-actions bot removed the automerge label Dec 9, 2022
@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: GeForce GTX 1080 









❌ OneFlow resnet50 time: 139.6ms (= 13958.8ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 160.1ms (= 16006.8ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.15 (= 160.1ms / 139.6ms)

OneFlow resnet50 time: 85.6ms (= 8556.0ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 101.7ms (= 10173.7ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.19 (= 101.7ms / 85.6ms)

OneFlow resnet50 time: 57.4ms (= 11480.6ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 88.3ms (= 17652.8ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.54 (= 88.3ms / 57.4ms)

OneFlow resnet50 time: 44.1ms (= 8824.7ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 82.0ms (= 16393.4ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.86 (= 82.0ms / 44.1ms)

OneFlow resnet50 time: 41.3ms (= 8257.4ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 76.9ms (= 15379.6ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.86 (= 76.9ms / 41.3ms)

@github-actions
Copy link
Contributor

CI failed when running job: cuda-misc. PR label automerge has been removed

@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: GeForce GTX 1080 









❌ OneFlow resnet50 time: 140.0ms (= 14004.1ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 160.0ms (= 15995.5ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.14 (= 160.0ms / 140.0ms)

OneFlow resnet50 time: 84.8ms (= 8479.8ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 102.0ms (= 10200.7ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.20 (= 102.0ms / 84.8ms)

OneFlow resnet50 time: 57.5ms (= 11500.6ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 78.4ms (= 15688.0ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.36 (= 78.4ms / 57.5ms)

OneFlow resnet50 time: 45.4ms (= 9073.2ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 71.4ms (= 14287.2ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.57 (= 71.4ms / 45.4ms)

OneFlow resnet50 time: 39.7ms (= 7932.4ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 76.3ms (= 15253.7ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.92 (= 76.3ms / 39.7ms)

@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: GeForce GTX 1080 









❌ OneFlow resnet50 time: 139.6ms (= 13963.1ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 161.6ms (= 16162.7ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.16 (= 161.6ms / 139.6ms)

OneFlow resnet50 time: 84.6ms (= 8458.9ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 102.4ms (= 10238.2ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.21 (= 102.4ms / 84.6ms)

OneFlow resnet50 time: 57.5ms (= 11492.4ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 77.2ms (= 15432.8ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.34 (= 77.2ms / 57.5ms)

OneFlow resnet50 time: 44.4ms (= 8882.7ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 70.9ms (= 14174.5ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.60 (= 70.9ms / 44.4ms)

OneFlow resnet50 time: 41.3ms (= 8269.5ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 67.3ms (= 13469.4ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.63 (= 67.3ms / 41.3ms)

@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: GeForce GTX 1080 









❌ OneFlow resnet50 time: 139.7ms (= 13965.6ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 160.5ms (= 16054.0ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.15 (= 160.5ms / 139.7ms)

OneFlow resnet50 time: 84.8ms (= 8480.2ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 100.9ms (= 10088.4ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.19 (= 100.9ms / 84.8ms)

OneFlow resnet50 time: 57.6ms (= 11520.8ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 88.1ms (= 17619.6ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.53 (= 88.1ms / 57.6ms)

OneFlow resnet50 time: 44.0ms (= 8796.1ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 69.5ms (= 13901.0ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.58 (= 69.5ms / 44.0ms)

OneFlow resnet50 time: 40.3ms (= 8055.5ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 73.0ms (= 14599.8ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.81 (= 73.0ms / 40.3ms)

@github-actions
Copy link
Contributor

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/9575/

strint
strint reviewed Dec 10, 2022
View reviewed changes
python/oneflow/distributed/launch.py
if args.redirect_stdout_and_stderr:
os.makedirs(log_directory_path, exist_ok=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里也是打开了 ONEFLOW_DEBUG_MDOE ，才会创建 log 目录么

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ONEFLOW_DEBUG_MODE=1时，会创建log文件夹存INFO日志以及prototxt、dot等debug文件；
给distributed.launch设置redirect_stdout_and_stderr时，会创建log文件夹存重定向的stdout和stderr

@mergify mergify bot merged commit 5f3beed into master Dec 10, 2022
@mergify mergify bot deleted the rm_distributed_log_dir branch December 10, 2022 10:09
@strint strint mentioned this pull request Dec 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strint strint strint approved these changes

@jackalcooper jackalcooper jackalcooper approved these changes

@BBuf BBuf Awaiting requested review from BBuf

@daquexian daquexian Awaiting requested review from daquexian

@oneflow-ci-bot oneflow-ci-bot Awaiting requested review from oneflow-ci-bot

Assignees
No one assigned
Labels
automerge enhancement system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shangguanshiyuan @strint @jackalcooper