Add New features： transforms.RandomGrayscale #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
这咋只有一个pass哈哈哈哈，如果torchvision也是用Pillow实现的话，这里对齐应该不难 |
我打算先把MOCOV3那边权重载一下再来搞这边，就先pass了一下2333 |
HiHippie
changed the title
OK没问题，按你的节奏来 |
rentainhe
reviewed
Mar 10, 2022
rentainhe
reviewed
Mar 10, 2022
|
这个PR可以今天推一下然后合并进去~ |
|
和主分支的changelog还有冲突，merge main一下后fix一下冲突~ |
已解决 |
rentainhe
previously approved these changes
Mar 11, 2022
kaijieshi7
reviewed
Mar 11, 2022
| @@ -988,3 +988,28 @@ def rotate( | |||
| return F_t.rotate( | |||
| img, matrix=matrix, interpolation=interpolation.value, expand=expand, fill=fill | |||
| ) | |||
|
|
|||
|
|
|||
| def rgb_to_grayscale(img: Tensor, num_output_channels: int = 1) -> Tensor: | |||
There was a problem hiding this comment.
img: Tensor 是不是限定了输入的只能是flow.tensor，不能说PIL？
There was a problem hiding this comment.
对齐torch的实现：
if not isinstance(img, flow.Tensor):
return F_pil.to_grayscale(img, num_output_channels)
return F_t.rgb_to_grayscale(img, num_output_channels)
|
|
||
| def __init__(self, p=0.1): | ||
| super().__init__() | ||
| self.p = p |
There was a problem hiding this comment.
assert一下p的范围吧，p给2好像代码会运行
HiHippie
commented
Mar 11, 2022
| - if num_output_channels = 1 : returned image is single channel | ||
| - if num_output_channels = 3 : returned image is 3 channel with r = g = b | ||
| """ | ||
| if not isinstance(img, flow.Tensor): |
There was a problem hiding this comment.
对齐torch，这里有处理非flow.tensor的代码
kaijieshi7
reviewed
Mar 11, 2022
| please, consider using meth:`~flowvision.transforms.functional.to_grayscale` with PIL Image. | ||
|
|
||
| Args: | ||
| img (PIL Image or Tensor): RGB Image to be converted to grayscale. |
rentainhe
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transforms.RandomGrayscale。