Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests falsifiability #109

Open
AkA84 opened this issue Mar 18, 2018 · 0 comments
Open

Tests falsifiability #109

AkA84 opened this issue Mar 18, 2018 · 0 comments

Comments

@AkA84
Copy link

AkA84 commented Mar 18, 2018

Hello! I wanted to contribute and add a waitWhileVisible method (based on our discussion in #20 ), but I can't seem to be able to falsify the tests: as long as there is a method with the given name the test passes, no matter if the method does anything at all.

I tried the same with already existing methods, namely wait and waitUntilVisible, and the result is the same: if I strip away the content of the method entirely

class Document {
  // ...
  async wait (cond) {}
}

the test still passes once I run npm run compile && npm run test

> WITH_BABEL=1 mocha dist_test --compilers js:babel-core/register --require babel-polyfill

  waitwait selector (1099ms)

  1 passing (1s)

I'm probably missing something obvious here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant