Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support import bridge by QR from photo library #146

Closed
joxl opened this issue Jul 12, 2018 · 8 comments
Closed

Support import bridge by QR from photo library #146

joxl opened this issue Jul 12, 2018 · 8 comments
Milestone

Comments

@joxl
Copy link

joxl commented Jul 12, 2018

When trying to get new (custom) bridges at bridges.torproject.org, you can choose to copy the raw text, or view a QR code. Copying the text proves to be very challenging from a mobile OS (tried Safari, Chrome, DuckDuckGo, and even Onion Browser -- using iOS 10.x) with mixed results. Taking a screenshot (or downloading image) of the QR code would be much easier. However, the custom bridges config only supports the live camera. It would be very convenient to be able to choose a QR image from my mobile photo library.

@eighthave
Copy link

We're trying to define standard URI formats for this kind of thing: https://trac.torproject.org/projects/tor/ticket/15035

@tladesignz
Copy link
Contributor

I agree, that would be nice to have! Could be good as a replacement for #124, which turns out to be more and more unfulfillable, because Meek is probably going away, unless somebody comes up with a greet idea.

@joxl
Copy link
Author

joxl commented Jul 17, 2018

We're trying to define standard URI formats for this kind of thing: https://trac.torproject.org/projects/tor/ticket/15035

Just out of curiosity, what are the current URI formats supported but the existing (live camera) QR reader? I just assumed that if a live camera could do it, scanning an existing photo would use the same mechanism. Although reading the Trac ticket, it does seem like the URI format needs improved.

@tladesignz
Copy link
Contributor

There's currently no URI, it's just a text mode QR code, with a JSON array in it. @eighthave mentioned the URI topic, so we would check on it, bevore implementing this feature. Because, if that would be done, we could forget about importing images and instead register as a handler for that custom URI.

@eighthave
Copy link

eighthave commented Jul 17, 2018 via email

@n8fr8
Copy link

n8fr8 commented Jul 17, 2018

I swear we had incorporated the format mentioned in the https://trac.torproject.org/projects/tor/ticket/15035 ticket somewhere. I think if you do the email request for bridges, it might include those? Otherwise, I do know with Orbot, we allow sharing of your own bridge configuration to a friend.

Anyhow, I like the proposal above for a format that brings up a useful page in case there is no suitable client installed. Of course, any change here would have to be supported by the bridges.tpo team.

@tladesignz
Copy link
Contributor

So, nothing has happened with the format in over a year.

I have implemented reading a QR code from an image in the photo library, finally:

guardianproject/poe@452cacd

Will be contained in the next release.

If anything happens with the standard URI, please open a new issue!

@tladesignz tladesignz added this to the 2.3.0 (was 2.4.0) milestone Oct 28, 2019
tladesignz added a commit that referenced this issue Oct 28, 2019
@eighthave
Copy link

7 months ago, I worked out the possible schemes for one-bridge URLs, it is mapped out in the issue linked here, with example code and docs:
https://trac.torproject.org/projects/tor/ticket/15035#comment:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants