Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reload favicons of bookmarks every time a bookmark gets selected #406

Closed
abdallahalsalmi opened this issue Jan 6, 2023 · 3 comments
Closed

Reload favicons of bookmarks every time a bookmark gets selected #406

abdallahalsalmi opened this issue Jan 6, 2023 · 3 comments
Assignees
@tladesignz
Milestone
2.8.4

Comments

@abdallahalsalmi
Copy link

Hi, we noticed the BBC logo (and other logos) on the landing page of Onion Browser (iphone SE, iOS: 16.2) do not appear.

The problem seems to vary from one device to another on the same model.

Sometimes the logo of Deutsche Welle doesn't appear either.
@tladesignz
Copy link
Contributor

Yeah, I know, but thanks for pushing this.

The reason is: The icons are loaded on first start. On difficult connections, esp. the first requests done might time out. It's never retried until you edit the bookmark.

I guess, there should be a mechanism that retries loading the favicons at random times.

@tladesignz tladesignz changed the title BBC logo on landing page not loading Retry loading favicons of bookmarks at random times Jan 9, 2023
@tladesignz tladesignz self-assigned this Jan 9, 2023
@tladesignz tladesignz added this to the 2.8.4 milestone Jan 9, 2023
@tladesignz tladesignz mentioned this issue Jan 9, 2023
Closed
@tladesignz tladesignz changed the title Retry loading favicons of bookmarks at random times Reload favicons of bookmarks every time a bookmark gets selected Jan 9, 2023
@tladesignz
Copy link
Contributor

Since favicons also change, maybe the easiest solution is to reload it every time a bookmark is selected?

tladesignz added a commit that referenced this issue Jan 9, 2023
@tladesignz
Fixed issue #406: Reload bookmark icon, every time a bookmarked websi…
94c6ed3 
…te is loaded, then cache for 24 hours.
@tladesignz
Copy link
Contributor

Ok, so icons will now be cached for 24 hours, then re-requested, if user navigates to the bookmarked website.

Might take a few weeks until released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tladesignz tladesignz

Labels
None yet
Projects
None yet
Milestone
2.8.4
Development

No branches or pull requests
2 participants
@tladesignz @abdallahalsalmi