HTTP web-interface: dark overlay remains on the screen after action is taken

[milicomm]

Checklist

• I am reporting a bug in the Onion OS - Any issues with the closed source frontend (MainUI), or RetroArch or any of the cores should be directed to their respective repositories
• I have reviewed the Onion Docs and did not find the answer
• I have searched the existing (open and closed) issues to ensure I do not log a duplicate

Onions OS Version

4.2.3

Miyoo Firmware Version

202306282128

Provide a clear and concise description of the issue

HTTP web interface
Once loaded, it has a nice contrast and things are nicely visible but as soon as action is taken, the dark overlay turns on.
On Chrome/Edge (based on Chromium) the overlay remains on the page even once the action is completed.
The only workaround is to refresh the page.

Steps to Reproduce

Start HTTP web interface in web browser

Upload file/take any action.

Page remains dark

Provide any additional context or information that may help us investigate your issue

No additional comments

[XK9274]

Hi there.

This is third party source.

Could you take a look at the repo https://github.com/filebrowser/filebrowser and see if this is reported/resolved there since our version?

If it's a known issue at source and has been fixed then we'll rebuild it & update our version.

[milicomm]

Hi there.

This is third party source.

Could you take a look at the repo https://github.com/filebrowser/filebrowser and see if this is reported/resolved there since our version?

If it's a known issue at source and has been fixed then we'll rebuild it & update our version.

Thank you
Was not aware that it is a 3rd party tool
Checked their issue log and managed to find a reported issue:

filebrowser/filebrowser#2582

Seems that they have committed the change of the CSS files:

langren1353/filebrowser-player@028c0ee

can we somehow access the CSS files to get it changed
or do we have to wait for the new release?

edit:
tested in preview mode and the change does work as it should.

line 1843:
change
display: none;
to
visibility: hidden;

line 1848 and line 1853
change
display: block;
to
visibility: visible;

[XK9274]

No problem at all.

Looking at their releases they provide ARMv7 dists here https://github.com/filebrowser/filebrowser/releases/tag/v2.26.0

You could test this in place of our binary which is https://github.com/OnionUI/Onion/tree/main/static/build/.tmp_update/bin

If you feel this fixes the problem and doesn't introduce any other bugs, you can PR it to contribute or let me know and i'll PR it.

Thanks for your investigations :)

PS. if you do PR it please include a link to this issue for context.

[milicomm]

Hi XK9274
Unfortunately, I am not a developer/programmer.
Using your bin or performing push/pull requests are things which I am not familiar with (occasionally I use Visual Studio and had it even somehow connected to some repos but that's where my knowledge ends).
Sorry :(

[XK9274]

Hi that's ok! you don't need to be a developer for this testing :)

https://github.com/filebrowser/filebrowser/releases/download/v2.26.0/linux-armv7-filebrowser.tar.gz

You can download this, unpack the files and copy the "filebrowser" file to your SD card to /mnt/SDCARD/.tmp_update/bin and overwrite the existing one (or rename the existing one so you can keep both)

Restart filebrowser via tweaks -> networks or just reboot the MMP and let filebrowser start on its own. Then test your issue again :)

If it fixes it, and you'd like to raise a PR to mark your contribution i can also walk you through this. If not i will raise it on your behalf

[milicomm]

Great! Allow me a few minutes.
Just need to do some work (and maybe a coffee) and will come back to you with the results

[XK9274]

Sure! no rush at all 👍

[milicomm]

Renamed original one, copied the one from the link you provided.
Turned on the console, enabled hotspot, connected to onion os wifi, checked the web interface, seems to be working fine and the overlay is no longer an issue.
Copied 3 files, renamed 2, deleted 3 files.
For me it looks like it is resolved by upgrading the file.
Thank you for the assistance with this one and sorry for me being blunt here.
When reading now the original post what to do, I think I overcomplicated it in my head as thought I need to download the whole bin, compile it and maybe push it to the console as some kind of "test release".
(again, way overcomplicated it in my head).

[XK9274]

Great thanks! & No it's not a problem at all. They provide pre-built binaries as some repos do which is very nice.. especially when they include armv7.

If core functionality is still working with the filebrowser binary i think we can merge it.

Do you feel comfortable setting up a PR? I can walk you through it over discord DM or here if you want? I will also test the new binary before it gets approved

[milicomm]

Sorry. I am not using Discord. I am a little bit too old for that.
Happy to follow any guidance and do any additional testing if needed

edit: despite link which explains how to create a pull request I am stuck with understanding which branch I should select

[XK9274]

Sorry. I am not using Discord. I am a little bit too old for that. Happy to follow any guidance and do any additional testing if needed

edit: despite link which explains how to create a pull request I am stuck with understanding which branch I should select

No problem.

You can select the main branch :)

So it will come from your fork -> OnionUI:main.

[milicomm]

I wouldn't be surprised if this is not the path that I should have followed.
Created a new fork into my GitHub, added pull request when selected to add the updated filebrowser.
merged and well... mentioned the issue in the description of my pull request.

I probably don't understand what is a fork, branch, pull or push request (at all) :-(

[XK9274]

Heh, that's ok - it looks like it merged into your own fork there. It would need pushing upstream to us.

I can create this one and co-author you in the commit if you'd like? Moving forwards I think I can spend some time making a guide that's a little easier to understand for contributing and put that on our website?

The PR you just created was the correct fork (the one you closed)

[milicomm]

Yeah. I think I messed it up even more.
Don't mind if you take it from here.
Seems I am just too old to understand the concept and how this works (despite https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests)
For me, this is a system which does not make any sense to me.
I never worked with pull/push/forks/branches/repositories.

I am truly sorry (and embarrassed as I guess for many this might be like riding a bike)

when co-authoring, could you please use the account below? (@edmunek) as I was about to close this account

[edmunek]

co-author

[XK9274]

Please don't be embarassed. Thankyou for trying and taking the time to get involved.

Github can be very confusing, took me a while to get the hang of it - i'll try and put something together to make it easier

And sure, i'll use edmunek as the coauth.

[milicomm]

Thank you. I really appreciate all the understanding and patience.

[milicomm]

BTW, just noticed, that the newer version offers nice progress info on the uploaded files.
previously it was only showing a progress bar, now it also shows the upload info