Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package Manager: Auto select emulators that has roms present #1228

Merged
merged 4 commits into from Dec 11, 2023
Merged

Package Manager: Auto select emulators that has roms present #1228

merged 4 commits into from Dec 11, 2023

Conversation

Aemiii91
Copy link
Member

@Aemiii91 Aemiii91 commented Oct 21, 2023 •
edited

Changes

  • Added detection of rom presence for each emulator
  • Added a cartridge icon to emulators with roms present
  • Added a 3rd state to the X toggle (none, auto, all)
  • When making a fresh install, users will have emulators with roms selected by default
  • Changed the "changed" indicator to a dot on the left of the items (instead of an asterisk behind the name)

Preview

PackageManager_000

@Aemiii91 Aemiii91 added the enhancement New or improved feature label Oct 21, 2023
@Aemiii91 Aemiii91 added this to the v4.3 milestone Oct 21, 2023
@Aemiii91 Aemiii91 self-assigned this Oct 21, 2023
@Aemiii91 Aemiii91 linked an issue Oct 21, 2023 that may be closed by this pull request
[Feature Request] - Pac-Man : automatically select emulators when roms are present #683
Closed
@XK9274 XK9274 self-requested a review December 3, 2023 18:08
XK9274
XK9274 approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@XK9274 XK9274 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions 👍👌

@schmurtzm schmurtzm added this pull request to the merge queue Dec 11, 2023
@schmurtzm
Copy link
Member

Tested, awesome improvement of Package Manager.

Merged via the queue into main with commit e7a3182 Dec 11, 2023
3 checks passed
@schmurtzm schmurtzm deleted the 683-feature-request-pac-man-automatically-select-emulators-when-roms-are-present branch December 11, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XK9274 XK9274 XK9274 approved these changes

Assignees

@Aemiii91 Aemiii91

Labels
enhancement New or improved feature
Projects
Onion Development
Status: ✅ Done / Ready for release
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.

[Feature Request] - Pac-Man : automatically select emulators when roms are present
3 participants
@Aemiii91 @schmurtzm @XK9274