Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Norwegian language (by @kasperlosa) #1241

Merged
merged 1 commit into from Dec 12, 2023
Merged

Added Norwegian language (by @kasperlosa) #1241

merged 1 commit into from Dec 12, 2023

Conversation

Aemiii91
Copy link
Member

Credit: @kasperlosa

@Aemiii91 Aemiii91 added the localization Translation or language specific issues label Oct 25, 2023
@Aemiii91 Aemiii91 self-assigned this Oct 25, 2023
@ianrobrien
Copy link

Are you a native Norwegian speaker? Some of these translations seem a little off, but Norwegian is my second language so I would defer to you if you speak the language natively.

@kasperlosa
Copy link

Are you a native Norwegian speaker? Some of these translations seem a little off, but Norwegian is my second language so I would defer to you if you speak the language natively.

Hi
Yes I am, but what are you specifically referring to?

@ianrobrien
Copy link

Hi @kasperlosa! Looks like I can just leave comments on the commit itself. Probably easiest to just do that there.

@ianrobrien
Copy link

I just cross-referenced the English resource and it makes more sense with the context.

I can approve this PR if this project needs someone who understands the language to do so.

ianrobrien
ianrobrien approved these changes Nov 7, 2023
View reviewed changes
Copy link

@ianrobrien ianrobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things that could be changed for consistency but overall I think it is good enough. I'll approve and you can decide if you want to make any further changes.

schmurtzm
schmurtzm approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@schmurtzm schmurtzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this new language files, do not hesitate if you have further improvements.

@schmurtzm schmurtzm added this pull request to the merge queue Dec 12, 2023
Merged via the queue into main with commit ff4f7bf Dec 12, 2023
2 checks passed
@schmurtzm schmurtzm deleted the add-no-lang branch December 12, 2023 00:45
@Aemiii91 Aemiii91 changed the title I18N: Added Norwegian language Added Norwegian language Jan 23, 2024
@Aemiii91 Aemiii91 changed the title Added Norwegian language Added Norwegian language (by @kasperlosa) Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmurtzm schmurtzm schmurtzm approved these changes

@ianrobrien ianrobrien ianrobrien approved these changes

Assignees

@Aemiii91 Aemiii91

Labels
localization Translation or language specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Aemiii91 @ianrobrien @kasperlosa @schmurtzm