Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Thai Language #1285

Merged
merged 3 commits into from Dec 17, 2023
Merged

Add Thai Language #1285

merged 3 commits into from Dec 17, 2023

Conversation

BankVana
Copy link
Contributor

As the discussion in #1273 I use FontForge to add Thai glyphs.

Steps:

  • Exo-2-Bold-Italic_Universal.ttf
    1. Adjust style for Thai font (Noto Sans Thai - Bold) to Bold Italic (Italic Angle = -8)
    2. Merge the Thai font into Exo-2-Bold-Italic_Universal
    3. Done!
  • wqy-microhei.ttc
    1. Make entire original glyphs in wqy-microhei.ttc as bold.
    2. Set Thai font (Noto Sans Thai - Bold) Em Size from 1000 to 2048
    3. Merge scaled Thai font into WenQuanYiMicroHei and WenQuanYiMicroHeiMono
    4. Set "weight class" and "style map" as Bold
    5. Generate TCC font by disabling "Merge tables across fonts", which requires the space about 9-10 MB
    6. Done!

@XK9274 XK9274 added the localization Translation or language specific issues label Dec 3, 2023
@schmurtzm schmurtzm added this pull request to the merge queue Dec 17, 2023
Merged via the queue into OnionUI:main with commit fdba026 Dec 17, 2023
2 checks passed
@Aemiii91
Copy link
Member

This change completely changed the look of wqy_microhei. I think we'll need to roll this back.

schmurtzm added a commit that referenced this pull request Jan 2, 2024
@schmurtzm
Revert "Add Thai Language (#1285)"
e1edbed 
This reverts commit fdba026.
@schmurtzm schmurtzm mentioned this pull request Jan 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 2, 2024
@schmurtzm
Revert "Add Thai Language" (#1353)
ed3c519 
Reverts #1285
Related to
#1285 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmurtzm schmurtzm schmurtzm approved these changes

Assignees

@BankVana BankVana

Labels
localization Translation or language specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BankVana @Aemiii91 @schmurtzm @XK9274