Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blue light filter improvements #1330

Merged
merged 101 commits into from Dec 17, 2023
Merged

Blue light filter improvements #1330

merged 101 commits into from Dec 17, 2023

Conversation

XK9274
Copy link
Member

@XK9274 XK9274 commented Dec 15, 2023

  • toggle is now a toggle menu icon
  • menu item for toggle and intensity are disabled while script is working to keep the sync (lock file in tmp)
  • intensity now changes in realtime & smooth fade
  • add hotkey of Menu + B for 2 seconds to enable BLF
  • some UI/fading improvements
  • tidy up
  • persistent across boots if manually enabled in tweaks via "Toggle now"
  • Ignore the schedule for the current session if a manual toggle is done with the hotkey (saves going into tweaks when it's bouncing) The logic behind this is:
    • If the user disables the BLF for some reason while schedule is enabled we'll skip the schedule for this session, the user can remove this flag (/tmp/.blfIgnoreSchedule) by flipping the schedule on/off.

    • I chose this method of wiping the schedule flag so if the user takes no action, when they restart the schedule is still on for the next session.

XK9274 and others added 30 commits August 28, 2023 01:23
Store RGB in a file
Allow tweaks to run with an arg to start the blf thread
Add blue light submenu
Add enable "now" menu item
Rework strength/enabling etc
Add schedule logic in tweaks
Add checker to keymon in the 15 second loop
Add guards into blue_light.sh
Add locking mechanism incase script gets spammed (should never happen)
Can be called even when "off"
Re-add enable now button
Don't turn on when enable is selected
- Add Hotkey Menu + B for 2 seconds to toggle
- Enable at boot if manually turned on previously
@XK9274 XK9274 self-assigned this Dec 16, 2023
@XK9274 XK9274 added this to the v4.3 milestone Dec 16, 2023
@XK9274 XK9274 added the enhancement New or improved feature label Dec 16, 2023
XK9274 and others added 5 commits December 16, 2023 01:32
The logic behind this is:

If the user disables the BLF for some reason while schedule is enabled we'll skip the schedule for this session, the user can remove this flag (/tmp/.blfIgnoreSchedule) by flipping the schedule on/off.

I chose this method of wiping the schedule flag so if the user takes no action, when they restart the schedule is still on for the next session.
@XK9274
Copy link
Member Author

XK9274 commented Dec 16, 2023

I'm done with this unless any other bugs come up.

Copy link
Member

@schmurtzm schmurtzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giant and awesome work, thanks for all the iterations to obtain this nice result ! 👍🏻

@schmurtzm schmurtzm closed this Dec 17, 2023
auto-merge was automatically disabled December 17, 2023 00:50

Pull request was closed

@schmurtzm schmurtzm reopened this Dec 17, 2023
@schmurtzm schmurtzm added this pull request to the merge queue Dec 17, 2023
Merged via the queue into main with commit ddc9a9a Dec 17, 2023
3 checks passed
@schmurtzm schmurtzm deleted the blue_light_improvements branch December 17, 2023 01:01
@XK9274 XK9274 changed the title FIX: Blue light filter improvements Blue light filter improvements Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New or improved feature
Projects
Status: Done / Ready for release
Development

Successfully merging this pull request may close these issues.

None yet

2 participants