New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blue light filter improvements #1330
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add blue light submenu Add enable "now" menu item Rework strength/enabling etc Add schedule logic in tweaks Add checker to keymon in the 15 second loop Add guards into blue_light.sh Add locking mechanism incase script gets spammed (should never happen)
Can be called even when "off"
…Onion into blue_light_improvements
The logic behind this is: If the user disables the BLF for some reason while schedule is enabled we'll skip the schedule for this session, the user can remove this flag (/tmp/.blfIgnoreSchedule) by flipping the schedule on/off. I chose this method of wiping the schedule flag so if the user takes no action, when they restart the schedule is still on for the next session.
I'm done with this unless any other bugs come up. |
schmurtzm
approved these changes
Dec 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giant and awesome work, thanks for all the iterations to obtain this nice result ! 👍🏻
auto-merge was automatically disabled
December 17, 2023 00:50
Pull request was closed
XK9274
changed the title
FIX: Blue light filter improvements
Blue light filter improvements
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user disables the BLF for some reason while schedule is enabled we'll skip the schedule for this session, the user can remove this flag (/tmp/.blfIgnoreSchedule) by flipping the schedule on/off.
I chose this method of wiping the schedule flag so if the user takes no action, when they restart the schedule is still on for the next session.