Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lockups entering apps or games #1369

Merged
merged 4 commits into from Jan 23, 2024
Merged

Fix lockups entering apps or games #1369

merged 4 commits into from Jan 23, 2024

Conversation

XK9274
Copy link
Member

@XK9274 XK9274 commented Jan 13, 2024

We've found this is caused by a weird config combination... where if a certain TZ is set in runtime, MainUI inherits it and it causes some loops/threads within MainUI to not break out (it gets stuck in a threaded loop which will never exit), so you get stuck at a "Loading" screen when entering Roms, or a complete freeze when entering Apps.

It could be a mismatch of TZ between MainUI and everything that runs "before" it.. IE: updater, customer/main etc. & The kernel will never know about the TZ as we can't insert it so early. This is speculation, the root cause i haven't found.

This is obvious when files are removed from the SD and the time/date of creation checked on a windows PC, the TZ metadata is sometimes bad.

This pr will:

  • Remove runtime.sh environments knowledge of the timezone, therefore MainUI no longer knows about the TZ either.
  • Pass cmd_to_run.sh the timezone for apps and games to be aware it's potentially changed, and to set theirs correctly
  • Tell BLF script about the TZ manually, as keymon now no longer knows the TZ.

TZ is already set in update_networking.sh main function so no changes needed there for anything called as they will inherit this TZ from their parent.

Games and apps will inherit this from pushing it through cmd_to_run.sh

To verify this PR:

  • Rename your .tmp_update/config directoy
  • Drop in the attached tainted config dir: config.zip
  • Open the search app with something in the search field
  • Hard power down with the power button
  • Power on & try and load an app or game -> freeze.

Add in the new runtime.sh from this PR and re-run the above steps, observe no freeze.

The TZ is still correctly passed to retroarch:
image

And any apps:
image

Aslong as they're a child of either update_networking or cmd_to_run.sh

XK9274 and others added 2 commits January 13, 2024 14:31
-Remove runtime.sh environments knowledge of the timezone
-Pass cmd_to_run.sh the timezone for apps and games to be aware it's potentially changed, and to set theirs correctly

TZ is already set in update_networking.sh main function so no changes needed there for anything called as they will inherit this TZ from their parent.

Games and apps will inherit this from pushing it through cmd_to_run.sh

Co-Authored-By: Aemiii91 <44569252+Aemiii91@users.noreply.github.com>
Co-Authored-By: Totofaki <16885275+Sichroteph@users.noreply.github.com>
Co-Authored-By: Schmurtz <schmurtzm@users.noreply.github.com>
Co-Authored-By: tGecko <tGecko@proton.me>
@XK9274 XK9274 self-assigned this Jan 13, 2024
@XK9274 XK9274 added the bug in onion Something isn't working label Jan 13, 2024
@XK9274 XK9274 added this to the v4.3 milestone Jan 13, 2024
@Aemiii91 Aemiii91 marked this pull request as ready for review January 23, 2024 19:48
@Aemiii91 Aemiii91 added this pull request to the merge queue Jan 23, 2024
Merged via the queue into main with commit 9c5dbcf Jan 23, 2024
2 checks passed
@Aemiii91 Aemiii91 deleted the fix-lockups-tz-related branch January 23, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug in onion Something isn't working
Projects
Status: Done / Ready for release
Development

Successfully merging this pull request may close these issues.

None yet

3 participants