New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PICO8 Wrapper improvements #1425
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set host_framerate_control to 0 according to https://www.lexaloffle.com/bbs/?pid=109259#p
Co-Authored-By: Schmurtz <schmurtzm@users.noreply.github.com>
- Removing libGLESv2.so to reduce ram usage,the one from Parasyte framework will be used. (steward-fu/nds@8743602) - set swappiness to 10 (reduce the use of swap)
host_framerate_control forced in launch.sh to allows 4.3 beta and RC users to benefit of the improvement.
…echos pixel_perfect could lead to issues raised re: none int scaled modes being blurry but they'd be a red herring as it's not required. only the 384x384 mode is scaled and it's done internally within pico by "-preblit_scale 3" which scales us from 128x128 to 384x384
XK9274
added
bug in onion
Something isn't working
enhancement
New or improved feature
and removed
bug in onion
Something isn't working
labels
Feb 14, 2024
XK9274
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shows 60FPS in Krystmans perf cart now. Great changes 👍
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 9, 2024
…#1535) Mouse can be tested in this cart (which is also available through splore): https://www.lexaloffle.com/bbs/?tid=3467 - Fixes menu button handling so it doesn't exit on "PRESSED" event (fixes being unable to screenshot, change brightness etc) (may take 2 presses) - Fixes mouse bounds from previous regression in #1425 - Adds option flags to onioncfg.json to: - Hide the mouse icon - Set custom mouse bounds in the config (mostly for testing purposes) - Remove the mouse hotkey altogether so it can be rebound to something else These values will default to: ```c #define MMIYOO_DEFAULT_MOUSE_HOTKEY 0 #define MMIYOO_DEFAULT_MOUSE_ICON 0 #define MMIYOO_DEFAULT_MOUSE_MINX 40 #define MMIYOO_DEFAULT_MOUSE_MINY 0 #define MMIYOO_DEFAULT_MOUSE_MAXX 280 #define MMIYOO_DEFAULT_MOUSE_MAXY 236 ``` If they do not exist in the json config file. Which should look like: ```json "mouse":{ "scaleFactor":1, "acceleration":4.0, "accelerationRate":1.5, "maxAcceleration":4.0, "incrementModifier":1.0, "disableMouseHotkey":0, "disableMouseIcon":1, "minx":40, "miny":0, "maxx":280, "maxy":236 }, ``` When: ```json "disableMouseHotkey":1, ``` Is set, L2 can be rebound to a different key with: ```json "customkeys":{ "A":"Z", "B":"X", "X":"ESCAPE", "Y":"D", "L1":"D", "L2":"D", <<<<<<<<<< "R1":"D", "R2":"D", "LeftDpad":"LEFT", "RightDpad":"RIGHT", "UpDpad":"UP", "DownDpad":"DOWN", "Start":"RETURN", "Select":"D", "Menu":"D" }, ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better FPS
Reduce ram usage