Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changed route component to render to prevent unmounting problems #285

Merged
merged 1 commit into from
Dec 9, 2021
Merged

fix: changed route component to render to prevent unmounting problems #285

merged 1 commit into from
Dec 9, 2021

Conversation

web-mi
Copy link
Contributor

@web-mi web-mi commented Dec 7, 2021

Fixes #COBH-4068

Proposed Changes

  • Changed route component attribute to render to prevent remounting of components
  • Removed useMemo from route rendering because its not required anymore
  • Changed some object deps to spreaded props to prevent triggering changes and forced reloads

@web-mi web-mi force-pushed the COBH-4068 branch 2 times, most recently from cb817d3 to 94294bb Compare December 8, 2021 15:30
@webatspeed webatspeed merged commit e9d55e8 into develop Dec 9, 2021
@koepferd koepferd deleted the COBH-4068 branch January 18, 2022 08:59
@timomayer timomayer mentioned this pull request Oct 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webatspeed webatspeed webatspeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@web-mi @webatspeed