Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ban user): dont close overlay by state update #970

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

RunzelRosinchen
Copy link
Contributor

Fixes #

Proposed Changes

@what-the-diff
Copy link

what-the-diff bot commented Jul 12, 2023

PR Summary

  • BanUser.tsx Enhancements
    Key improvements have been made in the 'BanUser.tsx' including the rearrangement of certain functions for added efficiency. With the refactoring of the 'BanUser' component and the introduction of a new 'BanUserOverlay' component, users should expect an improved user interface.

  • GroupChatInfo.tsx Updates
    The 'GroupChatInfo.tsx' file has seen changes in the import of 'BanUser' and the addition of the 'BanUserOverlay'. Adjustments were also made to the specific state parameters, thus refining the chat feature. Furthermore, a 'BanUserOverlay' component has been added, contributing to the user-friendly experience.

  • MessageItemComponent.tsx Modifications
    The 'MessageItemComponent.tsx' has integrated changes paralleling the ones in 'GroupChatInfo.tsx'. This involves the switching of import statements and the inclusion of a new state. In addition to this, the 'FlyoutMenu' component and a new 'BanUserOverlay' component have been added, promoting site efficiency.

  • Alterations in GroupChatHeader/index.tsx
    Changes in the 'GroupChatHeader/index.tsx' replicate those in 'GroupChatInfo.tsx' and 'MessageItemComponent.tsx'. This includes changes in the import of components and the addition of new components, which will undoubtedly foster a more efficient user experience.

@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RunzelRosinchen RunzelRosinchen requested a review from a user July 12, 2023 09:07
web-mi
web-mi previously approved these changes Jul 12, 2023
Co-authored-by: Vadim Makeev <vadim.makeev@virtual-identity.com>
@RunzelRosinchen RunzelRosinchen merged commit d3e19ff into develop Jul 12, 2023
7 checks passed
@RunzelRosinchen RunzelRosinchen deleted the fix/ban-user-overlay branch July 12, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants