Fixes #200 #201
Merged
Fixes #200 #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vancamti
reviewed
Nov 24, 2023
| @@ -177,7 +177,8 @@ def list_straten(request): | |||
| request = set_http_caching(request, "adressenregister", "short") | |||
| Gateway = request.adressenregister_gateway() | |||
| gemeente_niscode = request.matchdict.get("niscode") | |||
| straten = handle_gateway_response(Gateway.list_straten, gemeente_niscode) | |||
| include_homoniem = request.matchdict.get("include_homoniem", False) | |||
There was a problem hiding this comment.
matchdict bevat denk ik enkel parameters die in de route zitten. Ik vermoed dat include homoniem eerder een queryparam zal zijn ?
matchdict
If a route has matched during this request, this attribute will be a dictionary containing the values matched by the URL pattern associated with the route. If a route has not matched during this request, the value of this attribute will be None. See The Matchdict.
vancamti
reviewed
Nov 24, 2023
goessebr
requested changes
Nov 24, 2023
Comment on lines
183
to
185
| "homoniem": obj.homoniem( | ||
| include_homoniem=True if request.params.get("include_homoniem") else False | ||
| ), |
There was a problem hiding this comment.
include_homoniem is een parameter bij naam() ipv homoniem()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.