New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Etag tween to only ETag the crabpy_pyramid routes by default. #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow setting a custom wsdl for CRABpy.
* master: Update sphinxcontrib-httpdomain from 1.6.1 to 1.7.0
Closes-Issue: #46
Etag tween can be disabled entirely by setting `etag_tween_disabled` to True in the settings .ini - Default: False. When the tween is enabled, extra routes can be set to get etagged by this tween by adding the route names to the `generate_etag_for.list` setting in the .ini Programmatically, route names could also by added by adding them to the `crabpy_pyramid.GENERATE_ETAG_ROUTE_NAMES` list. Closes-Issue: #97
claeyswo
approved these changes
Jan 9, 2019
claeyswo
requested changes
Jan 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deze moet in de 0.8.0. 0.7.0 is al uit.
Check, heb DEV_0.8.0 van master gemaakt. |
claeyswo
added a commit
that referenced
this pull request
Jan 11, 2019
* Update Etag tween to only ETag the crabpy_pyramid routes by default. (#98) * Allow setting a custom wsdl for CRABpy. * Include capakey by default (#93) Closes-Issue: #46 * Update Etag tween to only ETag the crabpy_pyramid routes by default. Etag tween can be disabled entirely by setting `etag_tween_disabled` to True in the settings .ini - Default: False. When the tween is enabled, extra routes can be set to get etagged by this tween by adding the route names to the `generate_etag_for.list` setting in the .ini Programmatically, route names could also by added by adding them to the `crabpy_pyramid.GENERATE_ETAG_ROUTE_NAMES` list. Closes-Issue: #97 * Update setup.py * Update CHANGES.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.