Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid modifying tag when getting description #39

Merged

Conversation

simonschmidt
Copy link
Contributor

tags.description was inadvertently modifying the tag data,
causing subsequent uses of that tag to give incorrect results.

Example:

from language_tags import tags

a = len(tags.description('es-419'))
b = len(tags.description('es-419'))

# assert 4 == 7
assert a == b

tags.description was inadvertently modifying the tag data,
causing subsequent uses of that tag to give incorrect results.

Example:

from language_tags import tags

a = len(tags.description('es-419'))
b = len(tags.description('es-419'))

assert a == b
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) to 98.098% when pulling c9553f7 on simonschmidt:immutable-description into 2c727b9 on OnroerendErfgoed:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) to 98.098% when pulling c9553f7 on simonschmidt:immutable-description into 2c727b9 on OnroerendErfgoed:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) to 98.098% when pulling c9553f7 on simonschmidt:immutable-description into 2c727b9 on OnroerendErfgoed:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) to 98.098% when pulling c9553f7 on simonschmidt:immutable-description into 2c727b9 on OnroerendErfgoed:master.

@simonschmidt
Copy link
Contributor Author

I'm not sure why coveralls thinks coverage decreased

@cahytinne
Copy link
Contributor

Strange, I also don't understand why the coverage decreases. The solution looks good!

@cahytinne cahytinne merged commit acf999f into OnroerendErfgoed:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants