Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing fails with unknown languages #14

Closed
koenedaele opened this issue Feb 23, 2015 · 1 comment
Closed

Importing fails with unknown languages #14

koenedaele opened this issue Feb 23, 2015 · 1 comment
Assignees
@koenedaele
Labels
enhancement
Milestone
0.5.0

Comments

@koenedaele
Copy link
Member

Currently, when importing a provider that has labels in languages not yet present in the language table, the import will fail because of a reference violation (except maybe on SQLite). Should we add something similar to what Atramhasis does when importing a single concept from an external provider? Check if the language is valid according to IANA rules and if so, add it to the database as well.

@dieuska @BartSaelen Thoughts?
@koenedaele koenedaele modified the milestone: 0.2.1 Feb 23, 2015
@koenedaele koenedaele mentioned this issue Jun 3, 2015
Merged
@koenedaele koenedaele added this to the 0.5.0 milestone Jul 6, 2015
@koenedaele koenedaele assigned koenedaele and unassigned koenedaele Jul 6, 2015
@koenedaele
Copy link
Member Author

@BartSaelen If you have no objections, I'd let @TalissaJoly handle this.

koenedaele added a commit that referenced this issue Aug 29, 2015
@koenedaele
Import unknown languages. Refs #14
6def836
@koenedaele koenedaele self-assigned this Aug 30, 2015
koenedaele added a commit that referenced this issue Aug 30, 2015
@koenedaele
Update HISTORY.rst with language import. Refs #14.
2b047fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koenedaele koenedaele

Labels
enhancement
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
1 participant
@koenedaele