Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JoinedLoad of labels and notes #15

Closed
koenedaele opened this issue Mar 6, 2015 · 2 comments
Closed

JoinedLoad of labels and notes #15

koenedaele opened this issue Mar 6, 2015 · 2 comments
Milestone

Comments

@koenedaele
Copy link
Member

In a few methods we are not using a joinedload on labels and notes. See

  • _get_concept_scheme: Returns notes and labels but doesn't load them with the concept. Forcing 2 extra db queries
  • get_by_id: Returns a concept. Joined loading the most needed relations (labels and notes) would save 2 queries.
  • get_by_uri: Returns a concept. Joined loading the most needed relations (labels and notes) would save 2 queries..
@koenedaele
Copy link
Member Author

@BartSaelen If you have no objections, I'd let @TalissaJoly handle this.

@koenedaele koenedaele added this to the 0.5.0 milestone Jul 6, 2015
koenedaele added a commit that referenced this issue Jan 10, 2016
@koenedaele
Copy link
Member Author

Some quick tests show that this improves performance with a postgresql database. But it might reduce performance for an in-memory SQLite database. Still, that's not a common usecase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant