Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<ons-pull-hook> as a direct descendant of <ons-scroller> seem not correct #707

Closed
zack24q opened this issue Jun 2, 2015 · 3 comments
Closed

Comments

@zack24q
Copy link
Contributor

zack24q commented Jun 2, 2015

I put "ons-pull-hook" as a direct descendant of "ons-page", it works fine. But when i need to put "ons-pull-hook" in "ons-scroller", it seem not correct. Here is my operation,first i scroll the list to the bottom, so the list's postion is bottom, then i scroll the list up with mouse(not wheel), the “pull-to-refresh” behavior has been triggered. I think the “pull-to-refresh” behavior should be triggered only the list's postion is top. please see my codepen. Thanks!

@zack24q
Copy link
Contributor Author

zack24q commented Jun 2, 2015

I add the style ons-scroller { height: 100%; } .ons-scroller__content { height: 100%; overflow: scroll; } and solve this problem temporally. I hope this code will help you to fixed that problem.

@argelius
Copy link
Contributor

argelius commented Jun 2, 2015

Thanks @zack24q ! We will check this out.

If this solves the bug, don't hesitate to create a PR with the changes.

@zack24q
Copy link
Contributor Author

zack24q commented Jun 2, 2015

OK, I will.

argelius added a commit that referenced this issue Jun 5, 2015
Fix for ons-scroller and ons-carousel. Closes #707
@lock lock bot added the outdated label May 18, 2018
@lock lock bot unassigned frandiox May 18, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants