fix(ons): Fix setImmediate not defined bug for ES modules #2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ons.internal was calling a polyfill before it was created. This happens because ons is an external import so it is hoisted, but setup is inlined at build time, so the ons code was running before the setup code. This was supposed to be fixed by #2735 but that fix only worked for UMD, not for ESM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ons.internal was calling a polyfill before it was created. This happens
because ons is an external import so it is hoisted, but setup is inlined
at build time, so the ons code was running before the setup code.
This was supposed to be fixed by #2735 but that fix only worked for UMD,
not for ESM.