Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ons template test #716

Merged
merged 6 commits into from
Jun 5, 2015
Merged

Ons template test #716

merged 6 commits into from
Jun 5, 2015

Conversation

andipavllo
Copy link
Contributor

No description provided.

@argelius
Copy link
Contributor

argelius commented Jun 4, 2015

@andipavllo Please also test the createdCallback code. It should test if the content is correctly assigned to el.template and that the nodes are removed from the DOM.

@frandiox
Copy link
Contributor

frandiox commented Jun 5, 2015

It's actually a bit hard to decide, but I think it should be fix, yes :)

@andipavllo
Copy link
Contributor Author

I rebased the commit ;)

argelius added a commit that referenced this pull request Jun 5, 2015
@argelius
Merge pull request #716 from OnsenUI/ons-template-test
1c59117 
Ons template test
@argelius argelius merged commit 1c59117 into master Jun 5, 2015
@argelius argelius deleted the ons-template-test branch June 5, 2015 04:07
@argelius
Copy link
Contributor

argelius commented Jun 5, 2015

Thanks @andipavllo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andipavllo @argelius @frandiox