Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material Alert Dialog #933

Merged
merged 12 commits into from Oct 2, 2015
Merged

Material Alert Dialog #933

merged 12 commits into from Oct 2, 2015

Conversation

argelius
Copy link
Contributor

@argelius argelius commented Oct 2, 2015

No description provided.

@argelius
Copy link
Contributor Author

argelius commented Oct 2, 2015

Implemented the design and fixed the ons.notification.* methods.

@anatoo
I'm not sure about the classnames:

Right now it's like this:

alert-dialog--material-title--one

But I think this is better:

alert-dialog-title--material--one

Or even this:

alert-dialog--material__title--one

@anatoo
Copy link
Contributor

anatoo commented Oct 2, 2015

@argelius
hmm... "alert-dialog--material-title--one" class name looks strange.
Could you fix this naming as you say?

@argelius
Copy link
Contributor Author

argelius commented Oct 2, 2015

@anatoo I changed the class names.

Please merge if there are no problems.

anatoo added a commit that referenced this pull request Oct 2, 2015
@anatoo anatoo merged commit 983605d into master Oct 2, 2015
@anatoo anatoo deleted the md-alert branch October 2, 2015 08:03
@anatoo
Copy link
Contributor

anatoo commented Oct 2, 2015

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants