New vertical menu #156
Merged
New vertical menu #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierFernandezMendez
requested review from
daniel-grana,
gonzalo-martinez-imt,
patricia-martinez-imatia and
tomfacal
Closed
2 tasks
src/app/shared/header-button-menu/header-button-menu.component.html
Outdated
Show resolved
Hide resolved
patricia-martinez-imatia
requested changes
Nov 15, 2022
patricia-martinez-imatia
requested changes
Nov 16, 2022
There was a problem hiding this comment.
- I don't know this screen well, there is a descriptive text that doesn't fit on the card, a possible solution would be to give padding to the description and I think that the titles and descriptions should be aligned
- I think that the configuration button of the table should appear rotated 90 degrees so that it occupies less.
The settings menu currently appears collapsed at 1920px resolution, in this case it should appear open and collapsed at resolutions lower than 1280px
- The height of the container should be 100% of the page and avoid scrolling.
Also I would put a title and close button to collapse the menu similar to next image
- In screens like the following, the table should occupy 100% of the width and no blank space appears
|
SonarCloud Quality Gate failed.
|
…OntimizeWeb/ontimize-web-ngx-playground into feature/8.x.x-new-vertical-menu
…OntimizeWeb/ontimize-web-ngx-playground into feature/8.x.x-new-vertical-menu
…and table config button
tomfacal
approved these changes
Feb 9, 2023
daniel-grana
approved these changes
Feb 9, 2023
patricia-martinez-imatia
approved these changes
Feb 9, 2023
patricia-martinez-imatia
added a commit
that referenced
this pull request
Feb 10, 2023
* menu in process * menu finished * input cards added * side menu changes * new menu * structure changes * new menu component * viewencapsulation * containers component vetical menu * menu added * config collapsible * container changes * table config menu sidenav * bugs and code smells * bug fix * some review changes * card title aligned, config table screen fixed * table configuration button and menu changed * duplicated code fix * list and grid menu * grid config colapsible finished * sonarcloud fixes * configuration header component * sonarcloud rip * new structure component on data module * sonar cloud fixes * sonar cloud minor fixes * Deleted image because it isnot necessary * inputs card with image * some fixes * solved some bugs and config button desapears on grid screens * bug while closing the sidenav on a small screen * config button bug * collapsible config menu fixed * Fixed errors in aot compilation * Fixed errors in aot compililation * some desing changes * collapsible menu overflow changed * config button fixes * Fix private var when running production aot * page fixes * trying to fix dark mode issues * main theme created * dark mode fixes * dark mode inputs card menu added * Update DummyService provider * Fix collapsible menu scroll * layout fixes * configuration button container fixed * collapsible css fix * unsubcribed events * code fixes and images changed * custom item list fix * Added missed translation * Added build:themes script * Applied imfashion theme * Update home component * Update main container layout of all sections * Update grid and list sections * Fix collapsible menu * Register svg icons into ontimize * organize svg icons * Data section menu * Fix console error of data-structure component * Fixed table, list, grid configuration button * Media section menu * Modals & popus section menu * Layout section menu * Imported OChartModule in table module * Updated angular.json with chart styles * Added sqltypes * added new icons * modified grid images and buttons examples * Updated ontimize-web-ngx version * Updated package-lock * Added ontimize-web-ngx-charts * some padding fixed, console error fixed, overflow fixed * input icons by img label and new container color on inputs * new svg incons and new example component desing * changed theming version to 8.5.0 snapshot 0 * Set read-only='yes' in o-image * grind screen fixes * bg levels tests * grid screens fixed * table config fixed * fixed scroll on some pages * using theming 8.4.1, fixed grid basic screen, new label on dark mode and table config button * removed unused classes * Update snapshot versions and updated css styles * Updated start script * Updated ontimize-web-ngx-theming version * Updated ontimize styles --------- Co-authored-by: Patricia Martinez <32088627+patricia-martinez-imatia@users.noreply.github.com> Co-authored-by: IMATIASL\patricia.martinez <patricia.martinez@imatia.com> Co-authored-by: Daniel Graña Cousido <daniel.grana@imatia.com> Co-authored-by: Tomas Fuentes <tomasfacal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.