GDB-9509: Updated the cluster creation JSON configuration #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailradkov
force-pushed
the
GDB-9509-cluster-config
branch
2 times, most recently
from
e403989
to
a8cef1e
Compare
| @@ -48,7 +48,7 @@ spec: | |||
| sizeLimit: 10Mi | |||
| - name: cluster-config | |||
| configMap: | |||
| name: graphdb-cluster-config-configmap | |||
| name: {{ .Values.graphdb.clusterConfig.existingClusterConfig | default "graphdb-cluster-config-configmap" }} | |||
There was a problem hiding this comment.
I noticed that the patch job waits on the external proxy to be accessible, what if such service is not used?
There was a problem hiding this comment.
Although the chart allows you to set replicas: 0 for the cluster proxy, it doesn't support working without it, for now.
There was a problem hiding this comment.
So the clients would not be able to use it as they are not using proxies for the moment
yaskoo
approved these changes
Feb 14, 2024
- Added `.Values.graphdb.clusterConfig.transactionLogMaximumSizeGB` configuration for the cluster creation JSON configuration - Added `graphdb.clusterConfig.existingClusterConfig` for providing a custom cluster creation JSON configuration - Fixed URLs in the [README.md](README.md) that refer to the official GraphDB documentation - Fixed the cluster creation JSON configuration to use `messageSizeKB` instead of `messageSize`, see `graphdb.clusterConfig.messageSize`
mihailradkov
force-pushed
the
GDB-9509-cluster-config
branch
from
a8cef1e
to
123df8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
graphdb.clusterConfig.transactionLogMaximumSizeGBconfiguration for the cluster creation JSON configurationgraphdb.clusterConfig.existingClusterConfigfor providing a custom cluster creation JSON configurationmessageSizeKBinstead ofmessageSize, seegraphdb.clusterConfig.messageSize