Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDB-6329 - Hide toastr and info messages when license invalid #1380

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

DesiBorisova
Copy link
Contributor

@DesiBorisova DesiBorisova commented Apr 23, 2024

What?

When the license is invalid all views that need to send SPARQL queries to work will show a 'license expired' message. No toastr messages or warnings will appear.

Why?

The message is added to inform the user, in the clearest way possible, to update their license in order to regain functionality.

How?

I added the error template and license validity checks, where necessary.

Testing?

Some tests updated.

Screenshots?

image

@DesiBorisova DesiBorisova marked this pull request as draft April 23, 2024 11:11
@DesiBorisova DesiBorisova force-pushed the GDB-6329---no-errors-on-license-expired branch 2 times, most recently from 74d03b6 to 1be4c29 Compare May 2, 2024 10:56
@DesiBorisova
Copy link
Contributor Author

Jenkins retry build

@DesiBorisova DesiBorisova marked this pull request as ready for review May 2, 2024 15:14
@yordanalexandrov
Copy link
Contributor

There are some other places where the toastr notification is shown or an action which requires a valid license leads to an error.

  • Import screen would allow to choose files and after that show an error that the license is not valid.
  • Graph overview (Explore) would allow to initialte Clear repository and return an error.
  • TTYG would show an error toaster if the licence is bad.
  • Also although not tested the Cluster view might throw an error.

src/js/angular/core/directives.js Outdated Show resolved Hide resolved
src/js/angular/core/services/license.service.js Outdated Show resolved Hide resolved
@DesiBorisova DesiBorisova force-pushed the GDB-6329---no-errors-on-license-expired branch from 3c184b7 to 48e7cb6 Compare May 13, 2024 12:27
@svilenvelikov
Copy link
Contributor

There are some other places where the toastr notification is shown or an action which requires a valid license leads to an error.

  • Import screen would allow to choose files and after that show an error that the license is not valid.
  • Graph overview (Explore) would allow to initialte Clear repository and return an error.
  • TTYG would show an error toaster if the licence is bad.
  • Also although not tested the Cluster view might throw an error.

These are valid notes also and should be fixed!

@DesiBorisova DesiBorisova force-pushed the GDB-6329---no-errors-on-license-expired branch 2 times, most recently from d69dc4c to b70553e Compare May 14, 2024 12:23
@DesiBorisova DesiBorisova force-pushed the GDB-6329---no-errors-on-license-expired branch from b70553e to 6e6aaaa Compare May 14, 2024 15:43
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
17 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants