Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDB-10226: change import settings model #1390

Merged
merged 1 commit into from
May 10, 2024

Conversation

boyan-tonchev
Copy link
Contributor

What

Moved the "contextLink" property from the top level to the "parserSettings" object within the import settings model.

Why

During the update of import functionality, it was decided to relocate the "contextLink" property from its previous location under "parserSettings" to the root level of the import settings model. This change was necessary to align with the updated requirements for import settings, but this would break any existing integrations with this API and is not ok for a minor release.

How

The "contextLink" was moved to previous place in the "parserSettings".

## What
Moved the "contextLink" property from the top level to the "parserSettings" object within the import settings model.

## Why
During the update of import functionality, it was decided to relocate the "contextLink" property from its previous location under "parserSettings" to the root level of the import settings model. This change was necessary to align with the updated requirements for import settings, but this would break any existing integrations with this API and is not ok for a minor release.

## How
The "contextLink" was moved to previous place in the "parserSettings".
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
17 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@boyan-tonchev boyan-tonchev merged commit 3d58578 into master May 10, 2024
1 of 2 checks passed
@boyan-tonchev boyan-tonchev deleted the GDB-10226-update-import-settings-model branch May 10, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants