Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDB-10366 change batch reset behavior for folders #1439

Merged

Conversation

svilenvelikov
Copy link
Contributor

What

  • Don't filter out selected folders when doing batch reset;
  • The messages describing the added/removed statements are not displayed after the import finishes. They are only displayed after a page refresh.

Why

  • As we recently started sending the folders when doing batch import as well and they can now have an import status. This is in contrast with the old behavior where folders didn't have an import status;
  • There are flags (hasReplacedGraphs, hasAddedStatements and hasRemovedStatements) that are calculated when directives are created. These flags remain unchanged even if the import resource is modified.

How

  • Removed the folders filtering when collecting resources for batch reset;
  • Remove the flags from the import-resource-message and import-resource-status-info directives. The flags in import-resource-status-info were unused after the decision that the message should always be displayed.

svilenvelikov and others added 3 commits June 19, 2024 11:34
…llow folders to be batch imported as well and they can have an import status as well.

(cherry picked from commit cd9e7b2)
(cherry picked from commit 8a07dcc)
## What
The messages describing the added/removed statements are not displayed after the import finishes. They are only displayed after a page refresh.

## Why
There are flags (hasReplacedGraphs, hasAddedStatements and hasRemovedStatements) that are calculated when directives are created. These flags remain unchanged even if the import resource is modified.

## How
Remove the flags from the import-resource-message and import-resource-status-info directives. The flags in import-resource-status-info were unused after the decision that the message should always be displayed.

(cherry picked from commit dcc4a12)
Copy link

sonarcloud bot commented Jun 19, 2024

@svilenvelikov svilenvelikov merged commit f79fdc8 into 2.7 Jun 19, 2024
2 checks passed
@svilenvelikov svilenvelikov deleted the GDB-10366-10.7-change-batch-reset-behavior-for-folders branch June 19, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants