Changes horizontal orientation layout. #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What The layout orientation has been changed to horizontal. ## Why To improve the usage of the component. The old implementation had some issues with component height calculations when used on certain pages. The problem arose due to the parent-child relations of the original implementation, which did not account for horizontal alignment of YASQE, YASR, and the tab list. We attempted to address this using flexbox, but encountered unexpected issues with the component's clients. ## How The flexbox implementation has been removed. Now, the width of YASQE, YASGUI, and the tab list is set to 50% when YASGUI mode is horizontal. Added a listener that observes changes in the tabs list size. When the event occurs, the position of the YASR is recalculated to align it with the top of the tabs list component.
boyan-tonchev
force-pushed
the
changes-horizontal-layout
branch
from
fdb49ab
to
5f55a9c
Compare
|
Jenkins retry |
2 similar comments
|
Jenkins retry |
|
Jenkins retry |
svilenvelikov
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The layout orientation has been changed to horizontal.
Why
To improve the usage of the component. The old implementation had some issues with component height calculations when used on certain pages.
The problem arose due to the parent-child relations of the original implementation, which did not account for horizontal alignment of YASQE, YASR, and the tab list. We attempted to address this using flexbox, but encountered unexpected issues with the component's clients.
How
The flexbox implementation has been removed. Now, the width of YASQE, YASGUI, and the tab list is set to 50% when YASGUI mode is horizontal.
Added a listener that observes changes in the tabs list size. When the event occurs, the position of the YASR is recalculated to align it with the top of the tabs list component.