Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kokiri Tunic color weirdshot protection does not cover the entire crash range #1698

Closed
ETR-BTF opened this issue Sep 7, 2022 · 2 comments
Closed
Labels
Component: Cosmetics Affects the patching of cosmetics. Component: Patching Affects the patching of the ROM Type: Bug Something isn't working
Milestone

Comments

@ETR-BTF
Copy link

ETR-BTF commented Sep 7, 2022

It used to be thought that the crash would occur on "weird" weirdshot frames on all wads if the Green value of the Kokiri Tunic was over 0x98. To avoid the crashes, the randomizer would ban Green values over 0x98 when either Glitch Logic or No Logic was selected. However, recent developments suggest that this restriction would only help avoid crashes when the randomizer rom is injected into JP wads. It is believed that NA wads have their own range. Since the randomizer cannot possibly know which wad the rom will be injected into, all offending values should be avoided and not just the JP wad ones. Unfortunately, it is currently unknown what the offending values for NA wads are. These were determined for JP wads thru sheer testing. dotzo suspects that for NA wads it might be the byte formed by the 2nd nybble of Green and the first nybble of Blue, but hasn't done enough testing to be able to confidently confirm that hypothesis.

This was also discussed in #1686

@ETR-BTF ETR-BTF changed the title Kokiri Tunic color weirdshot protection does not cover the crash range for NA wads [Bug] Kokiri Tunic color weirdshot protection does not cover the crash range for NA wads Sep 7, 2022
@ETR-BTF
Copy link
Author

ETR-BTF commented Sep 11, 2022

Looks like it's a bit more complicated after all

im here to complain about weirdshot crashes again lol, it looks like even with injecting into a jp wad, there can still be some crashes. i got one today with #1598A5, and i repeated it to verify it was definitely the bad weirdshot frame that caused it

@ETR-BTF ETR-BTF changed the title [Bug] Kokiri Tunic color weirdshot protection does not cover the crash range for NA wads [Bug] Kokiri Tunic color weirdshot protection does not cover the entire crash range Sep 11, 2022
@Cuphat Cuphat added the Type: Bug Something isn't working label Mar 6, 2023
@Cuphat Cuphat changed the title [Bug] Kokiri Tunic color weirdshot protection does not cover the entire crash range Kokiri Tunic color weirdshot protection does not cover the entire crash range Mar 6, 2023
@fenhl fenhl added Component: Patching Affects the patching of the ROM Component: Cosmetics Affects the patching of cosmetics. labels Mar 6, 2023
@ETR-BTF ETR-BTF mentioned this issue Sep 30, 2023
@fenhl
Copy link
Collaborator

fenhl commented Sep 30, 2023

Closing per #1965 (comment). If anyone is still experiencing the crash on seeds both generated and patched on randomizer versions 7.1.96 or newer, please leave a comment and we will reopen this issue.

@fenhl fenhl closed this as completed Sep 30, 2023
@fenhl fenhl added this to the 8.0 milestone Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cosmetics Affects the patching of cosmetics. Component: Patching Affects the patching of the ROM Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants