Rainbow tunic #1965
Merged
Rainbow tunic #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Things I'm sure people will complain about:
|
fenhl
added
Type: Enhancement
rrealmuto
commented
Apr 28, 2023
Cuphat
reviewed
Apr 28, 2023
|
These are my proposed changes for version compatibility. You pushed yours as I was working on it. It's a softer fallthrough for rainbow tunics (similar to how rainbow navi behaves). Cuphat@1903c0d |
cjohnson57
approved these changes
May 6, 2023
|
Does that mean we can get rid of the color restriction for glitched/no logic? |
This was referenced Sep 30, 2023
|
I thought I already did. But yeah it seems to fix the bug. I can't weirdshot myself but I had someone who could make it consistently crash with the wrong color, and after the patch it wouldn't crash |
|
Oh, so you did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because people asked me to PR this. Does what the title suggests.
Video showing the rainbow effect
https://user-images.githubusercontent.com/5086838/235819047-46b4eb98-9afe-4ae4-96a1-41591518911c.mp4
Screenshot of the equipment screen icons when rainbow is selected (it's selected for Kokiri and Goron tunic in this seed).
