Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting to include dungeons in spawn entrance pool #1287

Closed
wants to merge 1 commit into from

Conversation

fenhl
Copy link
Collaborator

@fenhl fenhl commented Apr 6, 2021

As far as I know, dungeon entrances were left out of the entrance pool for spawn positions not because it would cause bugs but for balance reasons (spawning inside a dungeon or directly outside of it can bypass item requirements).

This PR converts the “Randomize Overworld Spawns” checkbox into a dropdown setting, where the existing options are called “Off” and “Balanced”, and a new “Full” option is added which includes dungeon entrances.

The presets which previously had the setting enabled are S4 Tournament and Hell Mode. S4 Tournament stays on Balanced while Hell Mode gets upgraded to Full.

@Zannick Zannick added Component: Randomizer Core Generally the core functions of the python Status: Needs Review Someone should be looking at it Status: Under Consideration Developers are considering whether to accept or decline the feature described labels May 7, 2021
@Roman971
Copy link
Collaborator

This is just my opinion, but I personally don't think we should include dungeon entrances in the spawn pool.
The main reason for this is the setting is designed to randomize the "overworld" spawn, and having the overworld spawn lead to a dungeon seems weird to me.
In theory, we could include only the dungeon exits (leading to the overworld), but even then I don't think it would be worth turning the setting into a dropdown (which increases the GUI complexity quite a bit), since basically every dungeon exit is in an area with already a lot of possible entrances that can be picked as spawns.

It's worth noting that grottos/graves are excluded purely for technical reasons, but they are intended to be part of the normal spawn pool and should be part of it again whenever I get around to fixing the issues with them.

@Zannick
Copy link
Member

Zannick commented May 31, 2021

I'm feeling the same way about the dungeon entrance spawns, so it looks like this isn't going to happen at this time.

@Zannick Zannick closed this May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Randomizer Core Generally the core functions of the python Status: Needs Review Someone should be looking at it Status: Under Consideration Developers are considering whether to accept or decline the feature described
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants