-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Narrow conditions for priority one-way handling #1440
Conversation
I want to ponder this more deeply, actually. If AGR can require all dungeons, then we'd need this to avoid having repeated failures due to not placing a warp to Graveyard/Shadow. |
I suppose the Nocturne warp could be enabled if there's a dungeon reward goal. |
And if there's a dungeon reward goal but no dungeon ER, we'd also need Requiem. But not Bolero. How often do we expect it to be the case that we'd need this in AGR? I can think of: bridge=dungeons, GBK=dungeons, maybe lacs? And then Bingo is random enough that I'd want to leave it enabled. |
Also bridge = meds and Gbk = stones or vice versa. Not sure what you're referring to with the Bingo comment. |
Bingo can have a lot of different types of goals. My point is that there's a lot of cases to cover and it could be more work to maintain an accurate list than to just have it always on for AGR. What's the motivation for this? Just to let AGR sometimes not have warp access to Shadow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unapproving for now, since I'd still like this in AGR for a few cases but we should allow it to narrow further (like Bolero can be excluded) as mentioned.
c970072
to
66cac32
Compare
Narrowed things down a bit:
|
I don't really understand the reasoning behind the token conditions, can you explain them? |
Bolero locks access to a bean patch skull so it locks a goal item if overworld skulls aren't shuffled. Nocturne locks access to a dungeon so it locks a goal item if dungeon skulls aren't shuffled (unless GTG or Ganon's are in there but I feel like forcing that is even less variety than priority one-ways). Requiem locks access to both a bean patch skull and a dungeon. |
Gotcha, I was thinking about it backwards since normally you'd check if those locations are shuffled to see if you care about doing stuff to them or not |
This optimization is intended for ALR to guarantee access to certain regions via one-ways earlier in the seed generation. It should only apply to AGR if there are necessarily goals locked behind these regions. It already does not apply to RO.