Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace non-ASCII characters in song names with question marks #2222

Open
wants to merge 1 commit into
base: Dev
Choose a base branch
from

Conversation

fenhl
Copy link
Collaborator

@fenhl fenhl commented May 14, 2024

This is a quick fix for two bugs with the song name display:

  • Characters in the Latin-1 Supplement block displaying as spaces
  • Characters that are neither Basic Latin nor Latin-1 Supplement triggering a “ValueError: byte must be in range(0, 256)” exception while patching cosmetics — even if the song name display setting is off

A more proper fix would be to convert song names into the encoding used for text boxes and display them using the text box font, which is something @GSKirox has been investigating and which should replace this PR if it ends up working.

@fenhl fenhl added Type: Bug Something isn't working Status: Needs Review Someone should be looking at it Status: Needs Testing Probably should be tested Component: Cosmetics Affects the patching of cosmetics and removed Status: Needs Testing Probably should be tested labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cosmetics Affects the patching of cosmetics Status: Needs Review Someone should be looking at it Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant