Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hostile lollipops in colorblind mode #462

Merged
merged 3 commits into from Nov 18, 2023

Conversation

AnotherCommander
Copy link
Member

This is an accessibility oriented pull request. The idea is to make hostile ships on the scanner more easily distinguishable for colorblind people.

The colorblind mode algorithms we have enhance contrast of displayed colors to make them easily distinguishable as different. Still, sometimes when there is a lot going on in the screen, some additional visual clues would be good for persons who have trouble distinguishing key colors, even if we modify the contrast to make it easier for them. With this PR, in addition to the colorblind filters in use, we change the lollipop blips of hostile ships to an X instead of a square. This way, it only takes one quick look on the scanner and all hostiles can be easily identified.

This is something I had wanted to add for a long time now and is also consistent with color blindness accessibility best practices (don't just change the color, change the shape of key game elements as well if you can).

@Zireael07
Copy link

Not colorblind, but I like the idea of having hostile lollipops have a different shape <3

@AnotherCommander AnotherCommander merged commit f936606 into master Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants