Merged craigbecks changes into mine, and then implemented some of the MKGeometry methods #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…od to remove warnings. no issues in build now :-)
I was getting webundefined errors becuase the page isn't fully setup by the time I got the mapViewDidFinishLoadingMap call. I modified the MapKit.html file to load things synchronously to avoid the mapViewDidFinishLoadingMap getting called before the page is fully loaded. I also updated the demo to use ARC (GC was causing build warnings), and moved some private code around a little.
|
Made some more changes, this time fixing some WebUndefined errors I was getting. |
|
Made the google links open in the default browser |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged craigbecks changes, which includes the code for the MapKitView+ZoomLevel, which I used to implement some of the methods in MKGeometry. I also implemented som tests for the MKGeometry methods.
Also, I reverted one of craigbeck's changes (to do with changing the header path) as I don't do static linking or whatever that change was for.