Fix issue 212 #372
Open
Fix issue 212 #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your submission! Could you outline a bit more detail on which packages are missing on windows/which errors occur? The idea was that opshin, being purely python, is indeed windows compatible. |
|
Note another option to fix this could be by choosing Nuitka. Maybe the easiest way to achieve multi platform compatibility is by using different bundlers? |
![codereviewbot-ai[bot]](https://avatars.githubusercontent.com/in/309638?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to bug bounty assigned to #212.
Adds a github workflow that on creation of a new release automatically builds binaries for linux and macos (tested both) and adds them to the assets section for download. See e.g. https://github.com/pcjordan/opshin/releases/tag/test-release-5.
I briefly tested windows as well but some of the python package dependencies are not available there, so this would likely require some more effort. Not sure if opshin was ever intended to be windows-compatible anyways?