feat: migrate to sepolia #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
zixiang2018
commented
Dec 27, 2023
|
|
||
| expect(getProviderConfig()).toEqual({ | ||
| networks: [{ name: "goerli", rpcUrl: "https://eth-goerli.alchemyapi.io/v2/_gg7wSSi0KMBsdKnGVfHDueq6xMB9EkC" }], | ||
| networks: [{ name: "sepolia", rpcUrl: "https://eth-sepolia.g.alchemy.com/v2/" }], |
There was a problem hiding this comment.
No default API key used here because we are using a workaround with manual URL (JsonRPCProvider) for ethers v5 to call Sepolia. Default API key will apply in ethers v6 when we use AlchemyProvider which supports Sepolia
|
🎉 This PR is included in version 9.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
ethersto v6 and use the sepolia-supported AlchemyProvider, which consist ofapiKeyproperty.TODOtag so that we will remember to revert the change in the future bumpethr-did-resolver(we are using the pre-ethers v6 version and v6 has support for Sepolia but is a breaking change)