Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to specify a component dependency on board #131

Closed
tcsunhao opened this issue Jun 2, 2022 · 5 comments · Fixed by #146
Closed

How to specify a component dependency on board #131

tcsunhao opened this issue Jun 2, 2022 · 5 comments · Fixed by #146
Assignees
@tcsunhao
Labels
Proposal Issue that contains a proposal for change of specification

Comments

@tcsunhao
Copy link
Contributor

tcsunhao commented Jun 2, 2022

From condition, we could know following condition attributes are supported.
image

Question is how to specify a component dependency on board? There is no board related attribute there.
@ReinhardKeil
Copy link
Collaborator

ReinhardKeil commented Jun 2, 2022 •
edited

@tcsunhao this is a feature gap that we should IMHO add.

PROPOSAL
Add to conditions element a way to filter for information from the boards element with:

Attribute Description
Bvendor Specifies board vendor
Bname Specifies board name
Brevision Specifies board revision

@ReinhardKeil ReinhardKeil added the Proposal Issue that contains a proposal for change of specification label Jun 2, 2022
@fred-r
Copy link
Contributor

fred-r commented Jun 2, 2022

We may even support the extension points in the conditions ?
@jkrech : what do you think ?

@jkrech
Copy link
Member

jkrech commented Jun 7, 2022

@fred-r, I think this needs to be reviewed as part of specifying: #27 but I do agree that we need to support the extension of attributes used to filter components for a given context.

@jkrech
Copy link
Member

jkrech commented Jun 7, 2022 •
edited

example:

  <require Bvendor="ARM" Bname="V2M-MPS2-SSE-200" Brevision="B" />

@ReinhardKeil
Copy link
Collaborator

added 'Bvendor', 'Bname', 'Brevision' attribute to conditions element to allow board specific filtering to Open-CMSIS-Spec

ReinhardKeil added a commit to ReinhardKeil/Open-CMSIS-Pack-Spec that referenced this issue Jul 19, 2022
@ReinhardKeil
Addressing Issues Open-CMSIS-Pack#131, Open-CMSIS-Pack#124, Open-CMSI…
fa985b7 
…S-Pack#141

     - added 'uuid' to boards element to indicate a 128-bit universal ID in the debug firmware of the board
     - added 'memory' and 'algorithm' child elements to the boards element to describe board-specific memory
     - added 'Bvendor', 'Bname', 'Brevision' attribute to conditions element to allow board specific filtering.
@JonatanAntoni JonatanAntoni mentioned this issue Jul 19, 2022
Merged
JonatanAntoni added a commit that referenced this issue Jul 19, 2022
@JonatanAntoni @ReinhardKeil
Addressing Issues #131, #124, #141
f67969d 
- added 'uuid' to boards element to indicate a 128-bit universal ID in the debug firmware of the board
- added 'memory' and 'algorithm' child elements to the boards element to describe board-specific memory
- added 'Bvendor', 'Bname', 'Brevision' attribute to conditions element to allow board specific filtering.

Co-authored-by: Reinhard Keil <reinhard.keil@arm.com>
@jkrech jkrech mentioned this issue Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcsunhao tcsunhao

Labels
Proposal Issue that contains a proposal for change of specification
Projects
Open-CMSIS-Pack Specification Change Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Addressing Issues #131, #124, #141 JonatanAntoni/Open-CMSIS-Pack-Spec
4 participants
@tcsunhao @fred-r @ReinhardKeil @jkrech