Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify cbuild schema check flag --schema #1261

Closed
ReinhardKeil opened this issue Jan 9, 2024 · 1 comment
Closed

Clarify cbuild schema check flag --schema #1261

ReinhardKeil opened this issue Jan 9, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ReinhardKeil
Copy link
Collaborator

ReinhardKeil commented Jan 9, 2024

Describe the bug

When cbuild is called with option --schema, on Windows the xmllint tool is required. Do we really need to check the XML input files? I believe the schema check should be limited to the YML input files.

Could you clearify what schema check is really enabled by this command? Is the csolution schema check disabled when this option is not used (csolution called with --no-check-schema)?

@ReinhardKeil ReinhardKeil added the bug Something isn't working label Jan 9, 2024
@jkrech
Copy link
Member

jkrech commented Jan 9, 2024

Currently YML and XML schema checks are unified, it's enabled or disabled for both (disabled by default).

When the cbuild tool runs with yml as input, there is no need to check the XML (cprj) schema as cprj is generated by the csolution tool.
Only when the cbuild tool command is buildcprj and therefore the input file must be a *.cprj file (cbuild buildcprj myproject.cprj) the --schema flag should invoke the xmllint tool on the specified *.cprj file.

@jkrech jkrech assigned soumeh01 and unassigned jkrech and brondani Jan 9, 2024
@jkrech jkrech changed the title Clearify cbuild schema check Clarify cbuild schema check flag --schema Jan 9, 2024
soumeh01 added a commit to Open-CMSIS-Pack/cbuild that referenced this issue Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

4 participants