Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selected-by: in *.cbuild-pack.yml file unclear #1263

Closed
ReinhardKeil opened this issue Jan 9, 2024 · 0 comments
Closed

selected-by: in *.cbuild-pack.yml file unclear #1263

ReinhardKeil opened this issue Jan 9, 2024 · 0 comments
Assignees
@Torbjorn-Svensson
Labels
enhancement New feature or request

Comments

@ReinhardKeil
Copy link
Collaborator

ReinhardKeil commented Jan 9, 2024 •
edited

Describe The Problem To Be Solved

The current implementation of *.cbuild-pack.yml file only records the explicit pack: statements. However in principal, packs are also selected by an device:, board:, or component: depending on the load strategy.

The content of attached example is:
DualCore.zip

It can be generated with:

csolution convert HelloWorld.csolution.yml --load all

and produces this *.cbuild-pack.yml file:

cbuild-pack:
  resolved-packs:
    - resolved-pack: ARM::CMSIS@6.0.0
    - resolved-pack: NXP::FRDM-K32L3A6_BSP@16.0.0
      selected-by:
        - NXP::FRDM-K32L3A6_BSP@16.0.0
    - resolved-pack: NXP::K32L3A60_DFP@16.0.0
      selected-by:
        - NXP::K32L3A60_DFP@16.0.0

Suggest A Solution

While I believe the current information is useful, it might be expanded in future versions. For now, I suggest to change the name of selected-by: to selected-by-pack:. This allows for future extensions where selected-by-device:, etc. could be introduced.

cbuild-pack:
  resolved-packs:
    - resolved-pack: ARM::CMSIS@6.0.0
    - resolved-pack: NXP::FRDM-K32L3A6_BSP@16.0.0
      selected-by-pack:
        - NXP::FRDM-K32L3A6_BSP@16.0.0
    - resolved-pack: NXP::K32L3A60_DFP@16.0.0
      selected-by-pack:
        - NXP::K32L3A60_DFP@16.0.0
@ReinhardKeil ReinhardKeil added the enhancement New feature or request label Jan 9, 2024
Torbjorn-Svensson added a commit to Torbjorn-Svensson/devtools that referenced this issue Jan 17, 2024
@Torbjorn-Svensson
[projmgr] Rename 'selected-by' to 'selected-by-pack' (Open-CMSIS-Pack…
d446476 
…#1263)

Contributed by STMicroelectronics

Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
jkrech pushed a commit that referenced this issue Jan 17, 2024
@Torbjorn-Svensson
[projmgr] Rename 'selected-by' to 'selected-by-pack' (#1263) (#1282)
eaad8cd 
Contributed by STMicroelectronics

Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Torbjorn-Svensson Torbjorn-Svensson

Labels
enhancement New feature or request
Projects
No open projects
CMSIS-Toolbox 2.3.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ReinhardKeil @Torbjorn-Svensson