Definition mismatch between Cvariant in pdsc and component in cproject yml file

[jeromecoutant]

From https://github.com/Open-CMSIS-Pack/Open-CMSIS-Pack-Spec/blob/main/schema/PACK.xsd#L329
Seems that variant name could be a string "with no condition"

In https://github.com/Open-CMSIS-Pack/devtools/blob/main/tools/projmgr/schemas/common.schema.json#L340
component and variant name are not "full" string and doesn't accept "(" for example

[jkrech]

@jeromecoutant this is something to discuss for all parts of the componentID.
Probably this should become a change request for the PACK.xsd schema to restrict the allowed characters and then align them with cproject/clayer schema file.

What exact requirements do you have/see?

[\-_a-zA-Z0-9]

[jeromecoutant]

Maybe space ?

edit: and "/" ?

ex:

ARM.CMSIS.pdsc:    <component Cclass="Device" Cgroup="Startup" Cvariant="C Startup"
Keil/MDK-Middleware/7.15.0/Keil.MDK-Middleware.pdsc:      <component Cgroup="CORE" Cvariant="IPv4/IPv6 Release"

[jkrech]

Analyzing current package descriptions listed in https://www.keil.com/pack/index.pidx we find in:
Cbundle, Cclass, Cgroup, Csub, Cvariant

A-Za-z0-9
space
_ - + . :' ( ) /

In conditions we additionally find * ?

No leading: space - + . ' / ( ) found

: today found in some Csub component descriptions is used as separator for component reference names in yml.

If we limit the use of : to Csub the parts should still be uniquely identified:

[Cvendor::] Cclass [&Cbundle] :Cgroup [:Csub] [&Cvariant] [@[~ | >=]Cversion]

because once Csub starts any further : needs to be considered being part of Csub.

[ReinhardKeil]

@jkrech can we come to a conclusion here? Are there changes suggested? What exactly should change?

[jkrech]

Both the Pack Schema File (https://github.com/Open-CMSIS-Pack/Open-CMSIS-Pack-Spec/tree/main/schema) as well as the csolution, cproject, clayer json schema files (https://github.com/Open-CMSIS-Pack/devtools/tree/main/tools/projmgr/schemas) shall be refined to restrict the allowed characters in componentIDs and to align on the exact same restrictions.

<xs:pattern value="[A-Za-z0-9_-+ . :' \(\)/ ]*"

[jkrech]

@soumeh01, could you please check the restrictions now present in PACK.xsd and match them with the componentID schema for the yml files so we are consistent.

[jkrech]

Will be part of cmsis-toolbox 1.5.0

[jkrech]

fixed in CMSIS-Toolbox 1.5.0