New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[projmgr] enforced component selection using extended component identifier #774
Comments
I've got some remarks and questions to this issue:
|
|
|
I believe that all files from a component can have conditions, not just config files. E.g. two copies of the "same" source file, one for ARMC6 and one for GCC. In that case I think we'd need to take some filtering into account when running the build. |
@mcgordonite you are right, so a filter for conditions at file level needs to be applied. |
…-CMSIS-Pack#774 (Open-CMSIS-Pack#516) * enforced component selection using extended component identifier Open-CMSIS-Pack#774 Co-authored-by: Evgueni Driouk <evgueni.driouk@arm.com>
@slhultgren please review the updated implementation for 1.7.0 and raise a new issue in case this does not meet your expectations. |
The fundamental principle of CMSIS-Pack components is that componentIDs are unique after the filter conditions for each component have been checked.
This proposal is introducing a way to uniquely identify a component independently of the filter conditions by specifying the full
<packID>
and<conditionID>
in addition to the<componentID>
.Extend the components node in cproject.yml/clayer.yml :
Note: this is the notation being used in
cbuild.yml
already today.A component with such an extended component identifier will be always be included in the processing, regardless of the result of the condition evaluation just like any other component.
If several components with the same
<componentID>
exist in the pack, it is required to add the<conditionID>
to identify the exact component to be included otherwise an error will be issued.The text was updated successfully, but these errors were encountered: