Modify underlying downloads and add more download materials #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhshkdz
previously approved these changes
Feb 11, 2021
There was a problem hiding this comment.
LGTM!
— Could we move the bibtex entry to the bottom of the page please.
— Let's add a note at the top of the page about dataset update. Maybe something like: NOTE: Data files for all tasks / splits were updated on Feb 10, 2021 due to minor bugs (affecting < 1% of the data) in earlier versions. If you downloaded data before Feb 10, please re-download the data.
mshuaibii
previously approved these changes
Feb 11, 2021
|
Looks good. I agree with Abhishek that we should include some details on the update to the dataset. Probably good to include a version history. |
clz55
requested changes
Feb 12, 2021
sidgoyal78
commented
Feb 12, 2021
|
|
||
|
|
||
|
|
||
| ## Dataset changelog |
There was a problem hiding this comment.
@clz55 , @abhshkdz , @mshuaibii : I added this, let me know if this seems okay.
abhshkdz
approved these changes
Feb 12, 2021
mshuaibii
approved these changes
Feb 12, 2021
clz55
approved these changes
Feb 12, 2021
levineds
pushed a commit
that referenced
this pull request
Jul 11, 2024
* Modify underlying downloads and add more download materials * Add checksum for mapping tables * download_data.py * Add changelog Co-authored-by: Muhammed Shuaibi <mshuaibi@andrew.cmu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following: