Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor concrete configs out of openeo-aggregator #117

Open
soxofaan opened this issue Sep 20, 2023 · 4 comments
Open

refactor concrete configs out of openeo-aggregator #117

soxofaan opened this issue Sep 20, 2023 · 4 comments

Comments

@soxofaan
Copy link
Member

As we're starting to play with multiple aggregator instances, it's confusing to have the original concrete (openeo platform) configs still hardcoded in this repo. It's probably better to refactor them out.
(would also help with #94)

@soxofaan
Copy link
Member Author

@soxofaan
Copy link
Member Author

I tried to work with more explicit env vars for clarity (replace ENV with OPENEO_AGGREGATOR_CONFIG), e.g. here:

docker_run_options_dev = ['-e OPENEO_AGGREGATOR_CONFIG=/home/openeo/aggregator/conf/aggregator.dev.py', '-p 8081:8080']
docker_run_options_prod = ['-e OPENEO_AGGREGATOR_CONFIG=/home/openeo/aggregator/conf/aggregator.prod.py', '-p 8081:8080']

but after a lot of head scratching I suspect these "docker_run_options" don't do anything anymore, the real env settings are now in puptap/hiera-resenv repo, as far as I understand

soxofaan added a commit that referenced this issue Sep 20, 2023
soxofaan added a commit that referenced this issue Sep 20, 2023
require full explicit config paths
soxofaan added a commit that referenced this issue Sep 20, 2023
require full explicit config paths
soxofaan added a commit that referenced this issue Sep 20, 2023
require full explicit config paths
soxofaan added a commit that referenced this issue Oct 4, 2023
now managed from hiera-resenv (see GDD-2861)
@soxofaan soxofaan self-assigned this Feb 2, 2024
@soxofaan
Copy link
Member Author

soxofaan commented Feb 7, 2024

started with new project openeo-platform-aggregator on VITO bitbucket

@soxofaan
Copy link
Member Author

Also to take into account here: https://github.com/Open-EO/openeo-aggregator/tree/master/integration-tests is currently openeo.cloud oriented as well. Make it more reusable or split off to standalone project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant