Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection metadata merging: support eo:bands summaries #81

Open
soxofaan opened this issue Nov 16, 2022 · 4 comments
Open

Collection metadata merging: support eo:bands summaries #81

soxofaan opened this issue Nov 16, 2022 · 4 comments

Comments

@soxofaan
Copy link
Member

common issue in https://github.com/openEOPlatform/architecture-docs/issues/288 :

(stac_summaries.py:142): Unhandled merging of StacSummaries for summary_name: 'eo:bands'

support for eo:bands is quite important (e.g. for band metadata support in python client)

@JeroenVerstraelen
Copy link
Contributor

Note that it is handled on this line:
https://github.com/Open-EO/openeo-aggregator/blob/master/src/openeo_aggregator/metadata/models/stac_summaries.py#L143

We currently only handle merging of these StacSummaries:

  • "constellation"
  • "platform"
  • "instruments"
  • summary starting with "sar:"
  • summary starting with "sat:"

@soxofaan
Copy link
Member Author

yes, I could easily add "eo:bands" there, but I wanted to add some parsing/validation too, in the style of the other "models".
However, I'm bit confused on how to do that, see e.g. #82

@jdries
Copy link
Contributor

jdries commented Mar 8, 2023

has this been fixed by these commits, or still an issue?

@soxofaan
Copy link
Member Author

It's been a while, I'm not sure. Have to find some time to verify this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants