Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple error messages for batch jobs #179

Closed
m-mohr opened this issue Apr 1, 2019 · 1 comment
Closed

Allow multiple error messages for batch jobs #179

m-mohr opened this issue Apr 1, 2019 · 1 comment
Labels
job management incl. /result
Milestone

Comments

@m-mohr
Copy link
Member

m-mohr commented Apr 1, 2019

In #165 we added a field/response that could contain a single error message for failed batch jobs. A single error message is a good start, but multiple error messages could be even more helpful. Therefore, I'd suggest to make it an array. That also simplifies the null handling as no error is simply an empty array, similar to how the validation handles it.

@m-mohr m-mohr added the job management incl. /result label Apr 1, 2019
@m-mohr m-mohr added this to the v0.5 milestone Apr 1, 2019
@m-mohr
Copy link
Member Author

m-mohr commented Oct 21, 2019

As the job should be stopped after the first error, I came to the conclusion that one error should be enough... More messages can be handled with logging as proposed in #214

@m-mohr m-mohr closed this as completed Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
job management incl. /result
Projects
None yet
Development

No branches or pull requests

1 participant